Convert have_id matcher argument to string.#31
Open
wildfiler wants to merge 2 commits intojsonapi-rb:masterfrom
Open
Convert have_id matcher argument to string.#31wildfiler wants to merge 2 commits intojsonapi-rb:masterfrom
wildfiler wants to merge 2 commits intojsonapi-rb:masterfrom
Conversation
Collaborator
|
@wildfiler I'm afraid your JSONAPI document is invalid if it is using integers:
I think the PR makes sense, as long as we convert just the |
Author
Collaborator
|
Nah, all good, please feel free to update it and I'll get it merged and released. Thank you! 🙇 |
wildfiler
force-pushed
the
fix-have-id-matcher
branch
from
8486008 to
27bbefd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
According to docs this two lines should be equivalent:
But the first line will fail if the
idvalue in the hash is a string, and the second line will fail if theidvalue is another type than a string.What is the new behavior?
Convert expected value and actual value to a string in the
have_idmatcher.Checklist
Please make sure the following requirements are complete:
features)